Skip to content

Pass RHS state to the pop-out#950

Merged
devinbinnie merged 3 commits intomasterfrom
update_github_plugin_rhs_popout
Jan 13, 2026
Merged

Pass RHS state to the pop-out#950
devinbinnie merged 3 commits intomasterfrom
update_github_plugin_rhs_popout

Conversation

@devinbinnie
Copy link
Member

@devinbinnie devinbinnie commented Dec 19, 2025

Summary

The GitHub plugin relies on certain state to be present for the RHS component to function properly. It also needs the content for that RHS component to be loaded.

This PR serves as an example for other plugins to update their code to work with the pop-out if it's not self-contained.

@devinbinnie devinbinnie requested review from a team and calebroseland and removed request for a team December 19, 2025 17:36
@devinbinnie devinbinnie requested a review from a team as a code owner December 19, 2025 17:36
@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label Dec 19, 2025
nevyangelova
nevyangelova approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinbinnie !

@marianunez marianunez added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 13, 2026
@mm-cloud-bot
Copy link

mm-cloud-bot commented Jan 13, 2026

Plugin Spinwick PR #950 🎉

Test server created!

Access here: https://github-pr-950-98x38.test.mattermost.cloud

Plugin Version Artifact
github 508ea71 Download

⚠️ Plugin Installation Issue

The test server was created successfully, but there was an issue installing or enabling the plugin automatically:

  • Install Error: failed to wait for S3 artifact: timed out waiting for S3 artifact

You can manually install the plugin:

  1. Download the plugin artifact from the link above
  2. Upload it to your test server at soqr4xt4gt8bbcc57ffacm6o7e
  3. Enable it in System Console > Plugins

Future commits will still attempt to automatically update the plugin.

Installation ID: soqr4xt4gt8bbcc57ffacm6o7e
Logs: Click here

Credentials: Posted securely in this Mattermost channel - Look for PR #950

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 13, 2026
@devinbinnie devinbinnie merged commit 5b995e7 into master Jan 13, 2026
13 checks passed
@devinbinnie devinbinnie deleted the update_github_plugin_rhs_popout branch January 13, 2026 16:26
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 13, 2026
@mm-cloud-bot
Copy link

mm-cloud-bot commented Jan 13, 2026

Test server destroyed

@mm-cloud-bot
Copy link

mm-cloud-bot commented Jan 13, 2026

Plugin test server update attempted, but encountered an issue:

⚠️ Install Error: failed to wait for S3 artifact: timed out waiting for S3 artifact

The test server is still available. You can manually download and install the updated plugin using the artifact link below.

Updated with git commit e132797edae62dcfbc509d9bd85f3e62f7deff94

Plugin Version Artifact
github e132797 Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calebroseland calebroseland calebroseland approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

Assignees

No one assigned

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devinbinnie @mm-cloud-bot @calebroseland @nevyangelova @marianunez @mattermost-build